base/json/json_file_value_serializer.cc - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_file_value_serializer.cc

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove redundant base:: prefix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_file_value_serializer.cc

diff --git a/base/json/json_file_value_serializer.cc b/base/json/json_file_value_serializer.cc

index 516f8765c428a5f8fe4ac888aee4729f0f942ef1..1a9b7a23b2044c4f467924c8a9546ac0276b52dd 100644

--- a/base/json/json_file_value_serializer.cc

+++ b/base/json/json_file_value_serializer.cc

@@ -101,7 +101,7 @@ const char* JSONFileValueDeserializer::GetErrorMessageForCode(int error_code) {

}

-scoped_ptr<base::Value> JSONFileValueDeserializer::Deserialize(

+std::unique_ptr<base::Value> JSONFileValueDeserializer::Deserialize(

int* error_code,

std::string* error_str) {

std::string json_string;