base/profiler/stack_sampling_profiler_unittest.cc - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/profiler/stack_sampling_profiler_unittest.cc

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/profiler/stack_sampling_profiler_unittest.cc

diff --git a/base/profiler/stack_sampling_profiler_unittest.cc b/base/profiler/stack_sampling_profiler_unittest.cc

index fad25a5929389512a47fc5095ffdbe9ab3c4f29e..12a05e150179c9a12c3cdadbb236343305f7a6cf 100644

--- a/base/profiler/stack_sampling_profiler_unittest.cc

+++ b/base/profiler/stack_sampling_profiler_unittest.cc

@@ -790,7 +790,7 @@ TEST(StackSamplingProfilerTest, MAYBE_DestroyProfilerWhileProfiling) {

CallStackProfiles profiles;

WithTargetThread([&params, &profiles](PlatformThreadId target_thread_id) {

- scoped_ptr<StackSamplingProfiler> profiler;

+ std::unique_ptr<StackSamplingProfiler> profiler;

profiler.reset(new StackSamplingProfiler(

target_thread_id, params, Bind(&SaveProfiles, Unretained(&profiles))));

profiler->Start();