Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185243002: [FastTextAutosizer] Fix incorrect override for RenderSVGShape::isEmpty (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

[FastTextAutosizer] Fix incorrect override for RenderSVGShape::isEmpty This patch fixes a crash on xe.com where the text autosizer would call isEmpty() on a RenderObject and crash. The issue is that RenderSVGShape overrides RenderObject::isEmpty and implements it differently: RenderObject::isEmpty() - true if the RenderObject has children RenderSVGShape::isEmpty() - true if the bounding box is empty I've refactored RenderSVGShape::isEmpty() as isShapeEmpty() to both clarify the override and fix a crash. BUG=302005 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168252

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update per reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
A LayoutTests/fast/text-autosizing/svg-path-crash.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/svg-path-crash-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
pdr
6 years, 9 months ago (2014-03-01 08:10:31 UTC) #1
f(malita)
LGTM + nits. https://codereview.chromium.org/185243002/diff/1/LayoutTests/fast/text-autosizing/svg-path-crash.html File LayoutTests/fast/text-autosizing/svg-path-crash.html (right): https://codereview.chromium.org/185243002/diff/1/LayoutTests/fast/text-autosizing/svg-path-crash.html#newcode16 LayoutTests/fast/text-autosizing/svg-path-crash.html:16: This test passes if it does ...
6 years, 9 months ago (2014-03-01 14:48:26 UTC) #2
pdr.
Thanks for the review. Off to the CQ https://codereview.chromium.org/185243002/diff/1/LayoutTests/fast/text-autosizing/svg-path-crash.html File LayoutTests/fast/text-autosizing/svg-path-crash.html (right): https://codereview.chromium.org/185243002/diff/1/LayoutTests/fast/text-autosizing/svg-path-crash.html#newcode16 LayoutTests/fast/text-autosizing/svg-path-crash.html:16: This ...
6 years, 9 months ago (2014-03-01 20:48:46 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-01 20:49:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/185243002/20001
6 years, 9 months ago (2014-03-01 20:49:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 22:38:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24168
6 years, 9 months ago (2014-03-01 22:38:50 UTC) #7
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-01 22:46:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/185243002/20001
6 years, 9 months ago (2014-03-01 22:46:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 01:05:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24177
6 years, 9 months ago (2014-03-02 01:05:49 UTC) #11
pdr.
On 2014/03/02 01:05:49, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-02 01:10:57 UTC) #12
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-02 01:11:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/185243002/20001
6 years, 9 months ago (2014-03-02 01:11:12 UTC) #14
pdr.
The CQ bit was unchecked by pdr@chromium.org
6 years, 9 months ago (2014-03-02 01:13:18 UTC) #15
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-02 01:13:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/185243002/20001
6 years, 9 months ago (2014-03-02 01:13:44 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-02 01:14:01 UTC) #18
Message was sent while issue was closed. 
Change committed as 168252

Powered by Google App Engine
This is Rietveld 408576698