Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/core/rendering/svg/RenderSVGShape.cpp

Issue 185243002: [FastTextAutosizer] Fix incorrect override for RenderSVGShape::isEmpty (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update per reviewer comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGShape.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/RenderSVGShape.cpp
diff --git a/Source/core/rendering/svg/RenderSVGShape.cpp b/Source/core/rendering/svg/RenderSVGShape.cpp
index 21655ff482b051d6aec876eaf153cde0e5cb6b20..b5c95287aeba6a2d9607367eb16c2f20df22fa19 100644
--- a/Source/core/rendering/svg/RenderSVGShape.cpp
+++ b/Source/core/rendering/svg/RenderSVGShape.cpp
@@ -63,7 +63,7 @@ void RenderSVGShape::updateShapeFromElement()
{
m_path.clear();
m_path = adoptPtr(new Path);
- ASSERT(RenderSVGShape::isEmpty());
+ ASSERT(RenderSVGShape::isShapeEmpty());
updatePathFromGraphicsElement(toSVGGraphicsElement(element()), path());
processMarkerPositions();
@@ -72,11 +72,6 @@ void RenderSVGShape::updateShapeFromElement()
m_strokeBoundingBox = calculateStrokeBoundingBox();
}
-bool RenderSVGShape::isEmpty() const
-{
- return path().isEmpty();
-}
-
void RenderSVGShape::fillShape(GraphicsContext* context) const
{
context->fillPath(path());
@@ -243,7 +238,7 @@ void RenderSVGShape::paint(PaintInfo& paintInfo, const LayoutPoint&)
{
ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
- if (paintInfo.context->paintingDisabled() || style()->visibility() == HIDDEN || isEmpty())
+ if (paintInfo.context->paintingDisabled() || style()->visibility() == HIDDEN || isShapeEmpty())
return;
FloatRect boundingBox = repaintRectInLocalCoordinates();
if (!SVGRenderSupport::paintInfoIntersectsRepaintRect(boundingBox, m_localTransform, paintInfo))
« no previous file with comments | « Source/core/rendering/svg/RenderSVGShape.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698