Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: runtime/vm/object.cc

Issue 1852393004: Fix background compilation issues when creating snapshots. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Allocate language errors in old space Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 9afe3fc37ceb3d49ad4d77fb5437a277ac0761c4..d19f1c32d3e64d6260b5ea8df2e6210dd5d8cf75 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -9435,10 +9435,10 @@ RawObject* Library::ResolveName(const String& name) const {
// are not cached. This reduces the size of the the cache.
return obj.raw();
}
- String& accessor_name = String::Handle(Field::GetterName(name));
+ String& accessor_name = String::Handle(Field::GetterSymbol(name));
siva 2016/04/04 22:45:38 Is this really correct? It ends up adding this nam
srdjan 2016/04/04 23:22:49 Done.
obj = LookupLocalObject(accessor_name);
if (obj.IsNull()) {
- accessor_name = Field::SetterName(name);
+ accessor_name = Field::SetterSymbol(name);
siva 2016/04/04 22:45:38 Ditto about adding the setter name to the symbol t
srdjan 2016/04/04 23:22:49 Done.
obj = LookupLocalObject(accessor_name);
if (obj.IsNull() && !ShouldBePrivate(name)) {
obj = LookupImportedObject(name);
« runtime/vm/dart_api_impl.cc ('K') | « runtime/vm/heap.h ('k') | runtime/vm/report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698