Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1852393004: Fix background compilation issues when creating snapshots. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Allocate language errors in old space Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 01ed58accef6608c1cda1b02d640abeeefdc0ca4..4dcdeb92fff22900715c35aac68924a732591851 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1483,6 +1483,10 @@ DART_EXPORT Dart_Handle Dart_CreateSnapshot(
return state;
}
I->heap()->CollectAllGarbage();
+ if (I->background_compiler() != NULL) {
+ BackgroundCompiler::Stop(I->background_compiler());
+ }
siva 2016/04/04 22:45:38 I was thinking of adding an Isolate::StopBackgroun
srdjan 2016/04/04 23:22:49 Done.
+
#if defined(DEBUG)
FunctionVisitor check_canonical(T);
I->heap()->IterateObjects(&check_canonical);
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/heap.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698