Fix background compilation issues when creating snapshots.

Fix background compilation issues when creating snapshots.
- Stop background compilation early enough
- Restore symbol table after completing snapshot writing.
- Create symbols instead fo strinfs (error caught with --no-use_lib_cache)

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/706ea554049c5809ede4126b9baa654fb4d71bbd

[srdjan, 2016-04-04 22:05:18]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-04-04 22:45:38]

I have one question about the change of Field::GetterName to Field::GetterSymbol

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1488: }
I was thinking of adding an Isolate::StopBackgroundCompiler method which did
that and you could call it here and in Isolate::Shutdown

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9438: String& accessor_name =
String::Handle(Field::GetterSymbol(name));
Is this really correct? It ends up adding this name to the symbol table.

Maybe you can do something similar to what is done in Namespace::Lookup and use
Field::LookupGetterSymbol that will not add anything to the symbol table.

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9441: accessor_name = Field::SetterSymbol(name);
Ditto about adding the setter name to the symbol table.

[srdjan, 2016-04-04 23:22:49]

PTAL

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1488: }
On 2016/04/04 22:45:38, siva wrote:
> I was thinking of adding an Isolate::StopBackgroundCompiler method which did
> that and you could call it here and in Isolate::Shutdown

Done.

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9438: String& accessor_name =
String::Handle(Field::GetterSymbol(name));
On 2016/04/04 22:45:38, siva wrote:
> Is this really correct? It ends up adding this name to the symbol table.
> 
> Maybe you can do something similar to what is done in Namespace::Lookup and
use
> Field::LookupGetterSymbol that will not add anything to the symbol table.

Done.

https://codereview.chromium.org/1852393004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9441: accessor_name = Field::SetterSymbol(name);
On 2016/04/04 22:45:38, siva wrote:
> Ditto about adding the setter name to the symbol table.

Done.

[siva, 2016-04-04 23:34:38]

lgtm

[srdjan, 2016-04-04 23:40:58]

Description was changed from

==========
Fix background compilation issues when creating snapshots.
- Stop background compilation early enough
- Restore symbol table after completing snapshot writing.
- Create symbols instead fo strinfs (error caught with --no-use_lib_cache)

BUG=
==========

to

==========
Fix background compilation issues when creating snapshots.
- Stop background compilation early enough
- Restore symbol table after completing snapshot writing.
- Create symbols instead fo strinfs (error caught with --no-use_lib_cache)

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706ea554049c5809ede4126b9baa654fb4d71bbd
==========

[srdjan, 2016-04-04 23:41:00]

Committed patchset #4 (id:60001) manually as
706ea554049c5809ede4126b9baa654fb4d71bbd (presubmit successful).