runtime/vm/dart_api_impl.cc - Issue 1852393004: Fix background compilation issues when creating snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1852393004: Fix background compilation issues when creating snapshots. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: more Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 01ed58accef6608c1cda1b02d640abeeefdc0ca4..fd0050dd4dc4337688e6d8b605c4a683eed16571 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1483,6 +1483,8 @@ DART_EXPORT Dart_Handle Dart_CreateSnapshot(

return state;

}

I->heap()->CollectAllGarbage();

+ I->StopBackgroundCompiler();

#if defined(DEBUG)

FunctionVisitor check_canonical(T);

I->heap()->IterateObjects(&check_canonical);

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »