Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1852373002: S390: Fixed MacroAssembler::ShiftRightArithPair to use SRDA (vs. SRDL) (Closed)

Created:
4 years, 8 months ago by bcleung
Modified:
4 years, 8 months ago
Reviewers:
michael_dawson, john.yan, JoranSiu, mtbrandyberry
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fixed MacroAssembler::ShiftRightArithPair to use SRDA (vs. SRDL) R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu@ca.ibm.com, BUG= Committed: https://crrev.com/6beb0690ec750fa3ad45407cb261206ade202265 Cr-Commit-Position: refs/heads/master@{#35246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/s390/macro-assembler-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
JoranSiu
lgtm
4 years, 8 months ago (2016-04-04 18:45:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852373002/1
4 years, 8 months ago (2016-04-04 18:52:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 19:13:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852373002/1
4 years, 8 months ago (2016-04-04 19:28:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 19:30:46 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:31:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6beb0690ec750fa3ad45407cb261206ade202265
Cr-Commit-Position: refs/heads/master@{#35246}

Powered by Google App Engine
This is Rietveld 408576698