Issue 185233002: DevTools: remove timeline presentation model dependency from record.

Issue 185233002: DevTools: remove timeline presentation model dependency from record. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
caseq, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: remove timeline presentation model dependency from record. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168282

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comments addressed. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -50 lines)			Patch
M	Source/devtools/front_end/TimelinePanel.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/TimelinePresentationModel.js	View	1	14 chunks	+54 lines, -37 lines	0 comments	Download
M	Source/devtools/front_end/TimelineUIUtils.js	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/TimelineView.js	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

caseq

lgtm https://codereview.chromium.org/185233002/diff/1/Source/devtools/front_end/TimelinePresentationModel.js File Source/devtools/front_end/TimelinePresentationModel.js (right): https://codereview.chromium.org/185233002/diff/1/Source/devtools/front_end/TimelinePresentationModel.js#newcode417 Source/devtools/front_end/TimelinePresentationModel.js:417: WebInspector.TimelinePresentationModel.InterRecordBindings = function() { style: { => next ...

6 years, 9 months ago (2014-03-03 08:22:36 UTC) #2

pfeldman

On 2014/03/03 08:22:36, caseq wrote: > lgtm > > https://codereview.chromium.org/185233002/diff/1/Source/devtools/front_end/TimelinePresentationModel.js > File Source/devtools/front_end/TimelinePresentationModel.js (right): > ...

6 years, 9 months ago (2014-03-03 09:22:30 UTC) #3

pfeldman

6 years, 9 months ago (2014-03-03 09:25:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r168282 (presubmit successful).

Expand Messages | Collapse Messages