Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: Source/devtools/front_end/TimelineView.js

Issue 185233002: DevTools: remove timeline presentation model dependency from record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineView.js
diff --git a/Source/devtools/front_end/TimelineView.js b/Source/devtools/front_end/TimelineView.js
index 423389879bbbeb7c3fdf3354e4c8f94f793bc8c1..5cbc4b58a29c0cff91ca375d51a963636833e0a6 100644
--- a/Source/devtools/front_end/TimelineView.js
+++ b/Source/devtools/front_end/TimelineView.js
@@ -34,16 +34,18 @@
* @extends {WebInspector.View}
* @implements {WebInspector.TimelineModeView}
* @param {!WebInspector.TimelineModeViewDelegate} delegate
+ * @param {!WebInspector.TimelineModel} model
* @param {!WebInspector.TimelinePresentationModel} presentationModel
* @param {?WebInspector.TimelineFrameModel} frameModel
*/
-WebInspector.TimelineView = function(delegate, presentationModel, frameModel)
+WebInspector.TimelineView = function(delegate, model, presentationModel, frameModel)
{
WebInspector.View.call(this);
this.element.classList.add("timeline-view");
this.element.classList.add("hbox");
this._delegate = delegate;
+ this._model = model;
this._presentationModel = presentationModel;
this._frameModel = frameModel;
this._calculator = new WebInspector.TimelineCalculator(this._presentationModel);
@@ -132,7 +134,7 @@ WebInspector.TimelineView.prototype = {
var dividerPosition = Math.round(positions.left);
if (dividerPosition < 0 || dividerPosition >= clientWidth || dividers[dividerPosition])
continue;
- var divider = WebInspector.TimelineUIUtils.createEventDivider(record.type, WebInspector.TimelineUIUtils.recordTitle(this._presentationModel, record));
+ var divider = WebInspector.TimelineUIUtils.createEventDivider(record.type, WebInspector.TimelineUIUtils.recordTitle(this._model, record));
divider.style.left = dividerPosition + "px";
dividers[dividerPosition] = divider;
}
@@ -803,7 +805,7 @@ WebInspector.TimelineView.prototype = {
if (anchor.row && anchor.row._record)
anchor.row._record.generatePopupContent(this._linkifier, showCallback);
else if (anchor._tasksInfo)
- popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent(this._presentationModel, anchor._tasksInfo), anchor, null, null, WebInspector.Popover.Orientation.Bottom);
+ popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent(this._model, anchor._tasksInfo), anchor, null, null, WebInspector.Popover.Orientation.Bottom);
}
function showCallback(popupContent)
« no previous file with comments | « Source/devtools/front_end/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698