Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: remoting/host/security_key/remote_security_key_message_writer_impl.h

Issue 1852283003: Updating Message Reader and Writer classes to use an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/remote_security_key_message_writer_impl.h
diff --git a/remoting/host/security_key/remote_security_key_message_writer.h b/remoting/host/security_key/remote_security_key_message_writer_impl.h
similarity index 65%
copy from remoting/host/security_key/remote_security_key_message_writer.h
copy to remoting/host/security_key/remote_security_key_message_writer_impl.h
index 1566e7990eddc0227e1f616bb5d72283cf025546..13d99e407eccc23522f8371b47a6de4b432d0d27 100644
--- a/remoting/host/security_key/remote_security_key_message_writer.h
+++ b/remoting/host/security_key/remote_security_key_message_writer_impl.h
@@ -2,40 +2,40 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_H_
-#define REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_H_
+#ifndef REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_IMPL_H_
+#define REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_IMPL_H_
#include <string>
#include "base/files/file.h"
#include "base/macros.h"
+#include "remoting/host/security_key/remote_security_key_message_writer.h"
#include "remoting/host/security_key/security_key_message.h"
namespace remoting {
// Used for sending remote security key messages using a file handle.
-class RemoteSecurityKeyMessageWriter {
+class RemoteSecurityKeyMessageWriterImpl
+ : public RemoteSecurityKeyMessageWriter {
public:
- explicit RemoteSecurityKeyMessageWriter(base::File output_file);
- ~RemoteSecurityKeyMessageWriter();
+ explicit RemoteSecurityKeyMessageWriterImpl(base::File output_file);
+ ~RemoteSecurityKeyMessageWriterImpl() override;
- // Writes a remote security key message w/o a payload to |output_stream_|.
- bool WriteMessage(RemoteSecurityKeyMessageType message_type);
-
- // Writes a remote security key message with a payload to |output_stream_|.
+ private:
+ // RemoteSecurityKeyMessageWriter interface.
+ bool WriteMessage(RemoteSecurityKeyMessageType message_type) override;
bool WriteMessageWithPayload(RemoteSecurityKeyMessageType message_type,
- const std::string& message_payload);
+ const std::string& message_payload) override;
- private:
// Writes |bytes_to_write| bytes from |message| to |output_stream_|.
bool WriteBytesToOutput(const char* message, int bytes_to_write);
base::File output_stream_;
bool write_failed_ = false;
- DISALLOW_COPY_AND_ASSIGN(RemoteSecurityKeyMessageWriter);
+ DISALLOW_COPY_AND_ASSIGN(RemoteSecurityKeyMessageWriterImpl);
};
} // namespace remoting
-#endif // REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_H_
+#endif // REMOTING_HOST_SECURITY_KEY_REMOTE_SECURITY_KEY_MESSAGE_WRITER_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698