Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: remoting/host/security_key/remote_security_key_message_writer.h

Issue 1852283003: Updating Message Reader and Writer classes to use an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/remote_security_key_message_writer.h
diff --git a/remoting/host/security_key/remote_security_key_message_writer.h b/remoting/host/security_key/remote_security_key_message_writer.h
index 1566e7990eddc0227e1f616bb5d72283cf025546..d18e34d62fcc75f78bc1192887e9a56edef559a7 100644
--- a/remoting/host/security_key/remote_security_key_message_writer.h
+++ b/remoting/host/security_key/remote_security_key_message_writer.h
@@ -7,7 +7,6 @@
#include <string>
-#include "base/files/file.h"
#include "base/macros.h"
#include "remoting/host/security_key/security_key_message.h"
@@ -16,24 +15,15 @@ namespace remoting {
// Used for sending remote security key messages using a file handle.
class RemoteSecurityKeyMessageWriter {
public:
- explicit RemoteSecurityKeyMessageWriter(base::File output_file);
- ~RemoteSecurityKeyMessageWriter();
+ virtual ~RemoteSecurityKeyMessageWriter() {}
// Writes a remote security key message w/o a payload to |output_stream_|.
- bool WriteMessage(RemoteSecurityKeyMessageType message_type);
+ virtual bool WriteMessage(RemoteSecurityKeyMessageType message_type) = 0;
// Writes a remote security key message with a payload to |output_stream_|.
- bool WriteMessageWithPayload(RemoteSecurityKeyMessageType message_type,
- const std::string& message_payload);
-
- private:
- // Writes |bytes_to_write| bytes from |message| to |output_stream_|.
- bool WriteBytesToOutput(const char* message, int bytes_to_write);
-
- base::File output_stream_;
- bool write_failed_ = false;
-
- DISALLOW_COPY_AND_ASSIGN(RemoteSecurityKeyMessageWriter);
+ virtual bool WriteMessageWithPayload(
+ RemoteSecurityKeyMessageType message_type,
+ const std::string& message_payload) = 0;
};
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698