Issue 1852193002: Remove LayoutView's special version mapToVisualRectInAncestorSpace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1852193002: Remove LayoutView's special version mapToVisualRectInAncestorSpace().

Created:
4 years, 8 months ago by Xianzhu

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@SVGRootClip

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove LayoutView's special version mapToVisualRectInAncestorSpace(). Move the specialty into LayoutView::mapContentRectToFrameSpace(), and call it from LayoutBox::mapToVisualRectInAncestorSpace() if the LayoutBox's container is a LayoutView. This avoids the IsFixed and InputRectIsInFrameCoordinates flags because the input rect of LayoutView::mapToVisualRectInAncestorSpace() is always in frame coordinates. BUG=598762

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -54 lines)			Patch
M	third_party/WebKit/Source/core/layout/LayoutBox.cpp	View	1 2	1 chunk	+8 lines, -13 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutView.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutView.cpp	View	1 2	2 chunks	+26 lines, -29 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp	View	1 2	5 chunks	+6 lines, -11 lines	0 comments	Download

Depends on Patchset:

Issue 1852183002 Patch 80001

Issue 1852193002: Remove LayoutView's special version mapToVisualRectInAncestorSpace().

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #