Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1852183002: Don't apply svg viewport clip when mapping a LayoutSVGRoot's own rect (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't apply svg viewport clip when mapping a LayoutSVGRoot's own rect BUG=597813 Committed: https://crrev.com/afa2305acd724e42643af1fcf0a9807be4f3df99 Cr-Commit-Position: refs/heads/master@{#385064}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : CORE_EXPORT SVGLayoutSupport for unit tests #

Patch Set 5 : CORE_EXPORT LayoutSVGRoot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -28 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 2 chunks +1 line, -22 lines 0 comments Download
A third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
Xianzhu
4 years, 8 months ago (2016-04-04 19:23:18 UTC) #2
pdr.
On 2016/04/04 at 19:23:18, wangxianzhu wrote: > Nice cleanup, LayoutSVGRootTest.cpp will be useful in the ...
4 years, 8 months ago (2016-04-04 19:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852183002/40001
4 years, 8 months ago (2016-04-04 22:09:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/45294)
4 years, 8 months ago (2016-04-04 22:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852183002/60001
4 years, 8 months ago (2016-04-04 22:50:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/45191) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-04 23:14:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852183002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852183002/80001
4 years, 8 months ago (2016-04-04 23:18:20 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-05 00:37:14 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 00:38:30 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/afa2305acd724e42643af1fcf0a9807be4f3df99
Cr-Commit-Position: refs/heads/master@{#385064}

Powered by Google App Engine
This is Rietveld 408576698