Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: pkg/analysis_server/lib/src/services/search/hierarchy.dart

Issue 1852113002: More strong mode changes in analysis_server (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/search/hierarchy.dart
diff --git a/pkg/analysis_server/lib/src/services/search/hierarchy.dart b/pkg/analysis_server/lib/src/services/search/hierarchy.dart
index f3ad992834dbbb71bf075072f68cd289c84c03a0..c6b552f523c018479ee88c1bbe67bca2262b3db1 100644
--- a/pkg/analysis_server/lib/src/services/search/hierarchy.dart
+++ b/pkg/analysis_server/lib/src/services/search/hierarchy.dart
@@ -35,13 +35,13 @@ List<Element> getClassMembers(ClassElement clazz, [String name]) {
List<Element> members = <Element>[];
visitChildren(clazz, (Element element) {
if (element.isSynthetic) {
- return;
+ return false;
}
if (element is ConstructorElement) {
- return;
+ return false;
}
if (name != null && element.displayName != name) {
- return;
+ return false;
}
if (element is ExecutableElement) {
members.add(element);
@@ -49,6 +49,7 @@ List<Element> getClassMembers(ClassElement clazz, [String name]) {
if (element is FieldElement) {
members.add(element);
}
+ return false;
});
return members;
}

Powered by Google App Engine
This is Rietveld 408576698