More strong mode changes in analysis_server

pkg/analysis_server/lib/src/services/search/hierarchy.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.hierarchy;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/services/search/element_visitors.dart';
@@ skipping 17 matching lines @@
 /**
  * Returns direct non-synthetic children of the given [ClassElement].
  *
  * Includes: fields, accessors and methods.
  * Excludes: constructors and synthetic elements.
  */
 List<Element> getClassMembers(ClassElement clazz, [String name]) {
   List<Element> members = <Element>[];
   visitChildren(clazz, (Element element) {
     if (element.isSynthetic) {
-      return;
+      return false;
     }
     if (element is ConstructorElement) {
-      return;
+      return false;
     }
     if (name != null && element.displayName != name) {
-      return;
+      return false;
     }
     if (element is ExecutableElement) {
       members.add(element);
     }
     if (element is FieldElement) {
       members.add(element);
     }
+    return false;
   });
   return members;
 }
 
 /**
  * Returns a [Set] with direct subclasses of [seed].
  */
 Future<Set<ClassElement>> getDirectSubClasses(
     SearchEngine searchEngine, ClassElement seed) {
   return searchEngine.searchSubtypes(seed).then((List<SearchMatch> matches) {
@@ skipping 118 matching lines @@
  * its variable, otherwise returns [element].
  */
 Element getSyntheticAccessorVariable(Element element) {
   if (element is PropertyAccessorElement) {
     if (element.isSynthetic) {
       return element.variable;
     }
   }
   return element;
 }