components/password_manager/core/browser/login_database_ios.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_ios.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/login_database_ios_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_ios.cc

diff --git a/components/password_manager/core/browser/login_database_ios.cc b/components/password_manager/core/browser/login_database_ios.cc

index 68812c25b237715061020bb048900a1855e1b2e8..4d965edd0e31271d8860a356643717089c174254 100644

--- a/components/password_manager/core/browser/login_database_ios.cc

+++ b/components/password_manager/core/browser/login_database_ios.cc

@@ -7,11 +7,12 @@

#import <Security/Security.h>

#include <stddef.h>

+#include <memory>

#include "base/base64.h"

#include "base/logging.h"

#include "base/mac/mac_logging.h"

#include "base/mac/scoped_cftyperef.h"

-#include "base/memory/scoped_ptr.h"

#include "base/metrics/sparse_histogram.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

@@ -101,7 +102,7 @@ LoginDatabase::EncryptionResult LoginDatabase::DecryptedString(

}

const size_t size = CFDataGetLength(data);

- scoped_ptr<UInt8[]> buffer(new UInt8[size]);

+ std::unique_ptr<UInt8[]> buffer(new UInt8[size]);

CFDataGetBytes(data, CFRangeMake(0, size), buffer.get());

CFRelease(data);