components/password_manager/core/browser/login_database.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/log_manager_unittest.cc ('k') | components/password_manager/core/browser/login_database_ios.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database.cc

diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc

index 897c155f69428e4f9db186137f7517e864128bff..0cc76ff353d7e289c6516e5d8be8550bb6b9061a 100644

--- a/components/password_manager/core/browser/login_database.cc

+++ b/components/password_manager/core/browser/login_database.cc

@@ -1318,7 +1318,7 @@ bool LoginDatabase::StatementToForms(

forms->clear();

while (statement->Step()) {

- scoped_ptr<PasswordForm> new_form(new PasswordForm());

+ std::unique_ptr<PasswordForm> new_form(new PasswordForm());

EncryptionResult result =

InitPasswordFormFromStatement(new_form.get(), *statement);

if (result == ENCRYPTION_RESULT_SERVICE_FAILURE)