Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 1852073002: Make sure to save/restore scroll positions in finishDelayUpdateScrollInfo (Closed)

Created:
4 years, 8 months ago by cbiesinger
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Make sure to save/restore scroll positions in finishDelayUpdateScrollInfo Due to Flexbox's multi-pass layout, we may lay out children at intermediate sizes that are very small, causing us to clamp the scroll position at this small size. Once we lay out at the right size, the scroll position is lost. To avoid this problem, make finishDelayUpdateScrollInfo store the old scroll position so it can be restored. XXXXX THIS IS TEMPORARY XXXXX The plan is to bake this on canary and merge this to M50 to fix the release blocker and fix this the right way on trunk (bug 600036), by delaying clamping of scroll offsets to after layout. BUG=593209 Review URL: https://codereview.chromium.org/1846023003 Cr-Commit-Position: refs/heads/master@{#384772} (cherry picked from commit ea799d37bd27d7ae346031a9332f542f7f57fd38) Committed: https://chromium.googlesource.com/chromium/src/+/638be1f77ce930f34389fc8040ccc1b014f91dfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 8 months ago (2016-04-03 01:17:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
638be1f77ce930f34389fc8040ccc1b014f91dfd.

Powered by Google App Engine
This is Rietveld 408576698