Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1852073002: Make sure to save/restore scroll positions in finishDelayUpdateScrollInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index 1f12215b6c69d8eec009026a975bbf743426d1e3..0a0684bc5e23ba6b281d7edd7ee22510b4ee0e4d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -837,7 +837,7 @@ void LayoutBlock::startDelayUpdateScrollInfo()
++gDelayUpdateScrollInfo;
}
-bool LayoutBlock::finishDelayUpdateScrollInfo(SubtreeLayoutScope* layoutScope)
+bool LayoutBlock::finishDelayUpdateScrollInfo(SubtreeLayoutScope* layoutScope, ScrollPositionMap* scrollMap)
{
bool childrenMarkedForRelayout = false;
@@ -851,7 +851,10 @@ bool LayoutBlock::finishDelayUpdateScrollInfo(SubtreeLayoutScope* layoutScope)
for (auto* block : *infoSet) {
if (block->hasOverflowClip()) {
- childrenMarkedForRelayout |= block->layer()->scrollableArea()->updateAfterLayout(layoutScope);
+ PaintLayerScrollableArea* scrollableArea = block->layer()->scrollableArea();
+ if (scrollMap)
+ scrollMap->add(scrollableArea, scrollableArea->scrollPositionDouble());
+ childrenMarkedForRelayout |= scrollableArea->updateAfterLayout(layoutScope);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698