Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 1851953002: Add API to set thread name (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
rmacnak, Chinmay
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M runtime/include/dart_tools_api.h View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 3 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/vm/os_thread.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os_thread.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 8 months ago (2016-04-01 20:38:17 UTC) #3
Chinmay
lgtm (not an owner). Do you want to remove |Dart_Timeline_Event_Metadata| now that there will be ...
4 years, 8 months ago (2016-04-01 21:18:53 UTC) #4
rmacnak
lgtm - I don't there's any reason to keep the metadata event kind since they ...
4 years, 8 months ago (2016-04-01 21:44:13 UTC) #5
Cutch
On 2016/04/01 21:44:13, rmacnak wrote: > lgtm - I don't there's any reason to keep ...
4 years, 8 months ago (2016-04-04 14:04:43 UTC) #6
Cutch
4 years, 8 months ago (2016-04-04 14:13:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6302c1cc41afe773740cd8f91fed6c1b2f27007e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698