Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 1851953002: Add API to set thread name (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/os_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 6cbf9f304bcb0e9fffca1b619ae1ee4a76c99630..7ccf6a0bda4eafc31c76e30dce7ff954b084e87b 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -9548,14 +9548,6 @@ TEST_CASE(Timeline_Dart_GlobalTimelineGetTrace) {
1,
&arg_names[0],
&arg_values[0]);
- // Add metadata to the embedder stream.
- Dart_TimelineEvent("METADATA_EVENT",
- Dart_TimelineGetMicros(),
- 0,
- Dart_Timeline_Event_Metadata,
- 0,
- NULL,
- NULL);
// Add counter to the embedder stream.
Dart_TimelineEvent("COUNTER_EVENT",
Dart_TimelineGetMicros(),
@@ -9564,6 +9556,7 @@ TEST_CASE(Timeline_Dart_GlobalTimelineGetTrace) {
0,
NULL,
NULL);
+ Dart_SetThreadName("CUSTOM THREAD NAME");
}
// Invoke main, which will be compiled resulting in a compiler event in
@@ -9608,8 +9601,8 @@ TEST_CASE(Timeline_Dart_GlobalTimelineGetTrace) {
EXPECT_SUBSTRING("TRACE_EVENT", buffer);
EXPECT_SUBSTRING("arg0", buffer);
EXPECT_SUBSTRING("value0", buffer);
- EXPECT_SUBSTRING("METADATA_EVENT", buffer);
EXPECT_SUBSTRING("COUNTER_EVENT", buffer);
+ EXPECT_SUBSTRING("CUSTOM THREAD NAME", buffer);
// Free buffer allocated by AppendStreamConsumer
free(data.buffer);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/os_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698