Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1851913002: Convert //sql to use std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //sql to use std::unique_ptr BUG=554298 Committed: https://crrev.com/d82cd995ba83303302900ebe7704a9fab405ef93 Cr-Commit-Position: refs/heads/master@{#386451}

Patch Set 1 #

Patch Set 2 : IWYU fix in resource_prefetch_predictor_tables.cc #

Patch Set 3 : IWYU fixup in precache_url_table_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -61 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 4 chunks +13 lines, -8 lines 0 comments Download
M components/precache/core/precache_url_table_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M sql/connection.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sql/connection.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M sql/connection_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M sql/recovery.h View 5 chunks +9 lines, -7 lines 0 comments Download
M sql/recovery.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M sql/recovery_unittest.cc View 20 chunks +39 lines, -19 lines 0 comments Download
M sql/test/sql_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M sql/test/test_helpers.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
Mostyn Bramley-Moore
@Scott: please take a look.
4 years, 8 months ago (2016-04-01 19:52:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851913002/1
4 years, 8 months ago (2016-04-01 19:52:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/198208)
4 years, 8 months ago (2016-04-01 22:24:16 UTC) #6
Mostyn Bramley-Moore
On 2016/04/01 22:24:16, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 8 months ago (2016-04-02 10:59:29 UTC) #7
Scott Hess - ex-Googler
lgtm
4 years, 8 months ago (2016-04-10 04:58:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851913002/1
4 years, 8 months ago (2016-04-10 06:43:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/157195)
4 years, 8 months ago (2016-04-10 06:54:34 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851913002/40001
4 years, 8 months ago (2016-04-11 07:52:02 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 08:56:13 UTC) #16
Mostyn Bramley-Moore
@sclittle: can you please give a thumbs-up for components/precache/core/precache_url_table_unittest.cc ? @pasko: can you please take ...
4 years, 8 months ago (2016-04-11 09:01:28 UTC) #18
pasko
On 2016/04/11 09:01:28, Mostyn Bramley-Moore wrote: > @pasko: can you please take a look at ...
4 years, 8 months ago (2016-04-11 11:36:05 UTC) #19
sclittle
components/precache/core/precache_url_table_unittest.cc LGTM
4 years, 8 months ago (2016-04-11 19:34:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851913002/40001
4 years, 8 months ago (2016-04-11 19:58:43 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-11 20:05:43 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:06:50 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d82cd995ba83303302900ebe7704a9fab405ef93
Cr-Commit-Position: refs/heads/master@{#386451}

Powered by Google App Engine
This is Rietveld 408576698