Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tables.cc

Issue 1851913002: Convert //sql to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU fixup in precache_url_table_unittest.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/precache/core/precache_url_table_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/predictors/resource_prefetch_predictor_tables.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tables.cc b/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
index c8e6877aa02bb035bfa7a789f407d5e111282245..c8093252e066a9b3ad6920b54427df3243508354 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
@@ -7,6 +7,7 @@
#include <stdint.h>
#include <algorithm>
+#include <memory>
#include <utility>
#include "base/logging.h"
@@ -316,8 +317,9 @@ bool ResourcePrefetchPredictorTables::UpdateDataHelper(
}
// Delete the older data from both the tables.
- scoped_ptr<Statement> deleter(data.is_host() ?
- GetHostResourceDeleteStatement() : GetUrlResourceDeleteStatement());
+ std::unique_ptr<Statement> deleter(data.is_host()
+ ? GetHostResourceDeleteStatement()
+ : GetUrlResourceDeleteStatement());
deleter->BindString(0, data.primary_key);
if (!deleter->Run())
return false;
@@ -332,15 +334,17 @@ bool ResourcePrefetchPredictorTables::UpdateDataHelper(
const ResourceRows& resources = data.resources;
for (ResourceRows::const_iterator it = resources.begin();
it != resources.end(); ++it) {
- scoped_ptr<Statement> resource_inserter(data.is_host() ?
- GetHostResourceUpdateStatement() : GetUrlResourceUpdateStatement());
+ std::unique_ptr<Statement> resource_inserter(
+ data.is_host() ? GetHostResourceUpdateStatement()
+ : GetUrlResourceUpdateStatement());
BindResourceRowToStatement(*it, data.primary_key, resource_inserter.get());
if (!resource_inserter->Run())
return false;
}
- scoped_ptr<Statement> metadata_inserter(data.is_host() ?
- GetHostMetadataUpdateStatement() : GetUrlMetadataUpdateStatement());
+ std::unique_ptr<Statement> metadata_inserter(
+ data.is_host() ? GetHostMetadataUpdateStatement()
+ : GetUrlMetadataUpdateStatement());
metadata_inserter->BindString(0, data.primary_key);
metadata_inserter->BindInt64(1, data.last_visit.ToInternalValue());
if (!metadata_inserter->Run())
@@ -356,8 +360,9 @@ void ResourcePrefetchPredictorTables::DeleteDataHelper(
for (std::vector<std::string>::const_iterator it = keys.begin();
it != keys.end(); ++it) {
- scoped_ptr<Statement> deleter(is_host ? GetHostResourceDeleteStatement() :
- GetUrlResourceDeleteStatement());
+ std::unique_ptr<Statement> deleter(is_host
+ ? GetHostResourceDeleteStatement()
+ : GetUrlResourceDeleteStatement());
deleter->BindString(0, *it);
deleter->Run();
« no previous file with comments | « no previous file | components/precache/core/precache_url_table_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698