android_webview/browser/find_helper.h - Issue 1851793002: Implement a shell of FindRequestManager, and hook it up to WebContentsImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/find_helper.h

Issue 1851793002: Implement a shell of FindRequestManager, and hook it up to WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and small fix. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/find_helper.h

diff --git a/android_webview/browser/find_helper.h b/android_webview/browser/find_helper.h

index a2e36e7f32b2b5a9e34b0fcea5670fc60eccf107..ada90849fa73da8ab0004cb79b9f8550c4f3d61a 100644

--- a/android_webview/browser/find_helper.h

+++ b/android_webview/browser/find_helper.h

@@ -43,7 +43,7 @@ class FindHelper : public content::WebContentsObserver {

void ClearMatches();

private:

- void StartNewRequest(const base::string16& search_string);

+ void StartNewSession(const base::string16& search_string);

bool MaybeHandleEmptySearch(const base::string16& search_string);

void NotifyResults(int active_ordinal, int match_count, bool finished);

« no previous file with comments | « no previous file | android_webview/browser/find_helper.cc » ('j') | no next file with comments »