Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: android_webview/browser/find_helper.cc

Issue 1851793002: Implement a shell of FindRequestManager, and hook it up to WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and small fix. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/find_helper.h ('k') | chrome/browser/ui/find_bar/find_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/find_helper.cc
diff --git a/android_webview/browser/find_helper.cc b/android_webview/browser/find_helper.cc
index 7eebbf22587c3fe2354498793f09b99727d7e241..8fc9979f607e3dbe782cf4120a199924977a3466 100644
--- a/android_webview/browser/find_helper.cc
+++ b/android_webview/browser/find_helper.cc
@@ -39,7 +39,7 @@ void FindHelper::FindAllAsync(const base::string16& search_string) {
async_find_started_ = true;
- StartNewRequest(search_string);
+ StartNewSession(search_string);
if (MaybeHandleEmptySearch(search_string))
return;
@@ -66,6 +66,8 @@ void FindHelper::FindNext(bool forward) {
if (!async_find_started_)
return;
+ current_request_id_ = find_request_id_counter_++;
+
if (MaybeHandleEmptySearch(last_search_string_))
return;
@@ -95,7 +97,7 @@ bool FindHelper::MaybeHandleEmptySearch(const base::string16& search_string) {
return true;
}
-void FindHelper::StartNewRequest(const base::string16& search_string) {
+void FindHelper::StartNewSession(const base::string16& search_string) {
current_request_id_ = find_request_id_counter_++;
last_search_string_ = search_string;
last_match_count_ = -1;
« no previous file with comments | « android_webview/browser/find_helper.h ('k') | chrome/browser/ui/find_bar/find_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698