Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1851743002: Simplify Supplementables post Oilpan. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tzik, webcomponents-bugzilla_chromium.org, eae+blinkwatch, fs, dcheng, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, jsbell+serviceworker_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-worker-reviews_chromium.org, nessy, sof, nhiroki, feature-media-reviews_chromium.org, eric.carlson_apple.com, darktears, jsbell+idb_chromium.org, vcarbune.chromium, philipj_slow, michaeln, mlamouri+watch-blink_chromium.org, tfarina, serviceworker-reviews, gasubic, falken, kinuko+serviceworker, cmumford, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Supplementables post Oilpan. R= BUG=585328 Committed: https://crrev.com/d1d6aed914d6333d4a1c6efb6b9e76d24498bed1 Cr-Commit-Position: refs/heads/master@{#384689}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : provide protected Supplementable() ctor #

Patch Set 4 : fix msvc compilation #

Patch Set 5 : rebased #

Patch Set 6 : rebased upto r384623 #

Patch Set 7 : fix component build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -331 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.h.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 2 3 4 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextFeatures.h View 1 2 3 4 3 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextFeatures.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Console.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Console.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 2 chunks +1 line, -30 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerClients.h View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerNavigator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerNavigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/WorkerGlobalScopeCrypto.h View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/WorkerGlobalScopeCrypto.cpp View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/RefCountedSupplement.h View 1 chunk +0 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/platform/Supplementable.h View 1 2 3 4 5 6 4 chunks +29 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-01 09:27:25 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-01 09:41:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851743002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851743002/100001
4 years, 8 months ago (2016-04-01 18:13:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/168016)
4 years, 8 months ago (2016-04-01 19:25:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851743002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851743002/120001
4 years, 8 months ago (2016-04-01 20:16:40 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-01 21:09:10 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 21:10:40 UTC) #14
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d1d6aed914d6333d4a1c6efb6b9e76d24498bed1
Cr-Commit-Position: refs/heads/master@{#384689}

Powered by Google App Engine
This is Rietveld 408576698