third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h - Issue 1851743002: Simplify Supplementables post Oilpan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h

Issue 1851743002: Simplify Supplementables post Oilpan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix component build Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h

diff --git a/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h b/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h

index 2887a8e48c2abffe20105f7fd4828cc915adefc6..93bc68dcf9e4f47f79822e5fb05ecadc355e1e0c 100644

--- a/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h

+++ b/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h

@@ -36,15 +36,15 @@ class ExceptionState;

class XPathExpression;

class XPathResult;

-class DocumentXPathEvaluator final : public GarbageCollected<DocumentXPathEvaluator>, public HeapSupplement<Document> {

+class DocumentXPathEvaluator final : public GarbageCollected<DocumentXPathEvaluator>, public Supplement<Document> {

USING_GARBAGE_COLLECTED_MIXIN(DocumentXPathEvaluator);

public:

- static DocumentXPathEvaluator& from(HeapSupplementable<Document>&);

+ static DocumentXPathEvaluator& from(Supplementable<Document>&);

- static XPathExpression* createExpression(HeapSupplementable<Document>&,

+ static XPathExpression* createExpression(Supplementable<Document>&,

const String& expression, XPathNSResolver*, ExceptionState&);

- static XPathNSResolver* createNSResolver(HeapSupplementable<Document>&, Node* nodeResolver);

- static XPathResult* evaluate(HeapSupplementable<Document>&,

+ static XPathNSResolver* createNSResolver(Supplementable<Document>&, Node* nodeResolver);

+ static XPathResult* evaluate(Supplementable<Document>&,

const String& expression, Node* contextNode, XPathNSResolver*,

unsigned short type, const ScriptValue&, ExceptionState&);