Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1851673006: Fix serial device PID and VID parsing (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix serial device PID and VID parsing Serial device's PID and VID contain hex digits, this patch fixed the code which parses it by adding "a-fA-F" to the regular expression. BUG=599101 Review URL: https://codereview.chromium.org/1848963002 Cr-Commit-Position: refs/heads/master@{#384414} (cherry picked from commit 66ecade99de4820622281ce4a17e511a4b6aa404) Committed: https://chromium.googlesource.com/chromium/src/+/ad10ef75e16235786db5f9d5346523870a6b8777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M device/serial/serial_device_enumerator_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
juncai
4 years, 8 months ago (2016-04-01 23:01:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad10ef75e16235786db5f9d5346523870a6b8777 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698