Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1848963002: Fix serial device PID and VID parsing (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix serial device PID and VID parsing Serial device's PID and VID contain hex digits, this patch fixed the code which parses it by adding "a-fA-F" to the regular expression. BUG=599101 Committed: https://crrev.com/66ecade99de4820622281ce4a17e511a4b6aa404 Cr-Commit-Position: refs/heads/master@{#384414}

Patch Set 1 : fixed serial device PID and VID parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M device/serial/serial_device_enumerator_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
juncai
Please take a look.
4 years, 8 months ago (2016-03-31 20:56:20 UTC) #3
Reilly Grant (use Gerrit)
lgtm
4 years, 8 months ago (2016-03-31 21:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848963002/1
4 years, 8 months ago (2016-03-31 21:09:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 22:15:04 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 22:16:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66ecade99de4820622281ce4a17e511a4b6aa404
Cr-Commit-Position: refs/heads/master@{#384414}

Powered by Google App Engine
This is Rietveld 408576698