Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1851663002: Gerrit git cl: do per CL check for Gerrit, not repo-wide. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer, Bons
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl: do per CL check for Gerrit, not repo-wide. The purpose is to allow mixed usage of Rietveld/Gerrit in the same repo. There, a branch can use Gerrit, even though repo's default is Rietveld. The only remaining repo-wide check GetIsGerrit is to determine codereview for a branch which has no uploads yet. This also simplifies future test expectations. R=andybons@chromium.org,bauerb@chromium.org BUG=598681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M git_cl.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/git_cl_test.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tandrii(chromium)
PTAL
4 years, 8 months ago (2016-03-31 21:41:57 UTC) #1
Bons
lgtm nice!
4 years, 8 months ago (2016-03-31 21:56:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851663002/1
4 years, 8 months ago (2016-03-31 22:24:04 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 22:26:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299603

Powered by Google App Engine
This is Rietveld 408576698