Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tests/git_cl_test.py

Issue 1851663002: Gerrit git cl: do per CL check for Gerrit, not repo-wide. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index df4a794a6c10be42de67d712091b07cb50750049..2e869a20ea910bb248c53b68eae3c2a970a0b357 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -784,9 +784,6 @@ class TestGitCl(TestCase):
return '\n'.join(branch_deps)
self.mock(git_cl, 'RunGit', mock_run_git)
- git_cl.settings = git_cl.Settings()
- self.mock(git_cl.settings, 'GetIsGerrit', lambda: False)
-
class RecordCalls:
times_called = 0
record_calls = RecordCalls()
@@ -808,6 +805,8 @@ class TestGitCl(TestCase):
return '123'
def GetPatchset(self):
return '1001'
+ def IsGerrit(self):
+ return False
ret = git_cl.upload_branch_deps(MockChangelist(), [])
# CMDupload should have been called 5 times because of 5 dependent branches.
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698