Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1851633002: Fix flaky DontReusePendingDeleteRenderViewHostForSubframe test. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky DontReusePendingDeleteRenderViewHostForSubframe test. BUG=599344 TEST=Test goes green on DrMemory bot. Committed: https://crrev.com/05a1cb791558af2b5ef244ffbf2681958880f8ed Cr-Commit-Position: refs/heads/master@{#384396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Charlie Reis
Alex, looks like your comment in the previous CL was correct about flakiness: https://codereview.chromium.org/1835833002/diff/80001/content/browser/site_per_process_browsertest.cc#newcode4188 Unfortunately, ...
4 years, 8 months ago (2016-03-31 20:52:44 UTC) #2
alexmos
On 2016/03/31 20:52:44, Charlie Reis wrote: > Alex, looks like your comment in the previous ...
4 years, 8 months ago (2016-03-31 21:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851633002/1
4 years, 8 months ago (2016-03-31 21:12:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 21:26:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 21:28:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05a1cb791558af2b5ef244ffbf2681958880f8ed
Cr-Commit-Position: refs/heads/master@{#384396}

Powered by Google App Engine
This is Rietveld 408576698