Fix flaky DontReusePendingDeleteRenderViewHostForSubframe test.

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 4158 matching lines @@
 }
 
 // Test for https://crbug.com/591478, where navigating to a cross-site page with
 // a subframe on the old site could cause the old RenderViewHost (now pending
 // deletion) to be reused.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
                        DontReusePendingDeleteRenderViewHostForSubframe) {
   GURL main_url(embedded_test_server()->GetURL("a.com", "/title1.html"));
   EXPECT_TRUE(NavigateToURL(shell(), main_url));
 
-  FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
-                            ->GetFrameTree()
-                            ->root();
-  RenderViewHostImpl* rvh_a = root->current_frame_host()->render_view_host();
-  int rvh_a_routing_id = rvh_a->GetRoutingID();
-
   std::string script =
       "window.onunload = function() { "
       "  var start = Date.now();"
       "  while (Date.now() - start < 1000);"
       "}";
   EXPECT_TRUE(ExecuteScript(shell()->web_contents(), script));
 
+  // Navigating cross-site with an iframe to the original site shouldn't crash.
   GURL second_url(embedded_test_server()->GetURL(
       "b.com", "/cross_site_iframe_factory.html?b(a)"));
   EXPECT_TRUE(NavigateToURL(shell(), second_url));
 
-  // We should have a different RVH for a.com.
-  RenderViewHostImpl* rvh_a2 =
-      root->child_at(0)->current_frame_host()->render_view_host();
-  EXPECT_NE(rvh_a_routing_id, rvh_a2->GetRoutingID());
+  // If the subframe is created while the main frame is pending deletion, then
+  // the RVH will be different.
+  // TODO(creis, alexmos): Find a way to assert this that isn't flaky.  For now,
+  // the test is just likely (not certain) to catch regressions by crashing.
 }
 
 // Check that when a cross-process frame acquires focus, the old focused frame
 // loses focus and fires blur events.  Starting on a page with a cross-site
 // subframe, simulate mouse clicks to switch focus from root frame to subframe
 // and then back to root frame.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
                        CrossProcessFocusChangeFiresBlurEvents) {
   GURL main_url(
       embedded_test_server()->GetURL("a.com", "/page_with_input_field.html"));
@@ skipping 2101 matching lines @@
   EXPECT_EQ(b_url, root->current_url());
 
   // Verify that the same RenderViewHost is preserved and that it is no longer
   // in swapped out state.
   EXPECT_EQ(rvh, contents->GetFrameTree()->GetRenderViewHost(
                      root->current_frame_host()->GetSiteInstance()));
   EXPECT_FALSE(rvh->is_swapped_out_);
 }
 
 }  // namespace content