Change store buffer overflow check to not rely on the store buffer being (2*Size) aligned.

Change store buffer overflow check to not rely on the store buffer being (2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO

Committed: https://crrev.com/6a628573883d0e9f22e397379f112cd7c68856a7
Cr-Commit-Position: refs/heads/master@{#35174}

[ulan, 2016-03-31 14:21:04]

Description was changed from

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This prepares for concurrent emptying of the store buffer.

BUG=chromium:578883
LOG=NO
==========

to

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This prepares for concurrent emptying of the store buffer without growing the
store buffer.

BUG=chromium:578883
LOG=NO
==========

[ulan, 2016-03-31 14:21:29]

Description was changed from

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This prepares for concurrent emptying of the store buffer without growing the
store buffer.

BUG=chromium:578883
LOG=NO
==========

to

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This prepares for concurrent emptying of the store buffer without double the
memory allocated for the store buffer.

BUG=chromium:578883
LOG=NO
==========

[ulan, 2016-03-31 14:57:02]

Description was changed from

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This prepares for concurrent emptying of the store buffer without double the
memory allocated for the store buffer.

BUG=chromium:578883
LOG=NO
==========

to

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO
==========

[ulan, 2016-03-31 14:59:49]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-03-31 14:59:50]

PTAL

[Michael Lippautz, 2016-03-31 15:44:52]

lgtm

This is how I feel about this patch: http://i.imgur.com/lBP18PF.gif

https://codereview.chromium.org/1851473002/diff/40001/src/heap/store-buffer.h
File src/heap/store-buffer.h (right):

https://codereview.chromium.org/1851473002/diff/40001/src/heap/store-buffer.h...
src/heap/store-buffer.h:23: static const int kStoreBufferLength =
kStoreBufferSize / sizeof(Address);
nit: kStoreBufferLength is unused. Let's remove it.

[ulan, 2016-03-31 16:23:14]

Thanks!

https://codereview.chromium.org/1851473002/diff/40001/src/heap/store-buffer.h
File src/heap/store-buffer.h (right):

https://codereview.chromium.org/1851473002/diff/40001/src/heap/store-buffer.h...
src/heap/store-buffer.h:23: static const int kStoreBufferLength =
kStoreBufferSize / sizeof(Address);
On 2016/03/31 at 15:44:52, Michael Lippautz wrote:
> nit: kStoreBufferLength is unused. Let's remove it.

Done

[ulan, 2016-03-31 16:49:58]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-03-31 16:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1851473002/#ps60001
(title: "Remove kStoreBufferLength")

[commit-bot: I haz the power, 2016-03-31 16:50:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851473002/60001

[commit-bot: I haz the power, 2016-03-31 17:17:35]

Description was changed from

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO
==========

to

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO
==========

[commit-bot: I haz the power, 2016-03-31 17:17:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-31 17:18:55]

Description was changed from

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO
==========

to

==========
Change store buffer overflow check to not rely on the store buffer being
(2*Size) aligned.

This reduces the reserved virtual memory size needed for the store buffer.

BUG=chromium:578883
LOG=NO

Committed: https://crrev.com/6a628573883d0e9f22e397379f112cd7c68856a7
Cr-Commit-Position: refs/heads/master@{#35174}
==========

[commit-bot: I haz the power, 2016-03-31 17:18:56]

Patchset 4 (id:??) landed as
https://crrev.com/6a628573883d0e9f22e397379f112cd7c68856a7
Cr-Commit-Position: refs/heads/master@{#35174}