Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: src/s390/macro-assembler-s390.cc

Issue 1851473002: Change store buffer overflow check to not rely on the store buffer being (2*Size) aligned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove kStoreBufferLength Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <assert.h> // For assert 5 #include <assert.h> // For assert
6 #include <limits.h> // For LONG_MIN, LONG_MAX. 6 #include <limits.h> // For LONG_MIN, LONG_MAX.
7 7
8 #if V8_TARGET_ARCH_S390 8 #if V8_TARGET_ARCH_S390
9 9
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 ExternalReference::store_buffer_top(isolate()); 533 ExternalReference::store_buffer_top(isolate());
534 mov(ip, Operand(store_buffer)); 534 mov(ip, Operand(store_buffer));
535 LoadP(scratch, MemOperand(ip)); 535 LoadP(scratch, MemOperand(ip));
536 // Store pointer to buffer and increment buffer top. 536 // Store pointer to buffer and increment buffer top.
537 StoreP(address, MemOperand(scratch)); 537 StoreP(address, MemOperand(scratch));
538 AddP(scratch, Operand(kPointerSize)); 538 AddP(scratch, Operand(kPointerSize));
539 // Write back new top of buffer. 539 // Write back new top of buffer.
540 StoreP(scratch, MemOperand(ip)); 540 StoreP(scratch, MemOperand(ip));
541 // Call stub on end of buffer. 541 // Call stub on end of buffer.
542 // Check for end of buffer. 542 // Check for end of buffer.
543 AndP(scratch, Operand(StoreBuffer::kStoreBufferOverflowBit)); 543 AndP(scratch, Operand(StoreBuffer::kStoreBufferMask));
544 544
545 if (and_then == kFallThroughAtEnd) { 545 if (and_then == kFallThroughAtEnd) {
546 beq(&done, Label::kNear); 546 bne(&done, Label::kNear);
547 } else { 547 } else {
548 DCHECK(and_then == kReturnAtEnd); 548 DCHECK(and_then == kReturnAtEnd);
549 beq(&done, Label::kNear); 549 bne(&done, Label::kNear);
550 } 550 }
551 push(r14); 551 push(r14);
552 StoreBufferOverflowStub store_buffer_overflow(isolate(), fp_mode); 552 StoreBufferOverflowStub store_buffer_overflow(isolate(), fp_mode);
553 CallStub(&store_buffer_overflow); 553 CallStub(&store_buffer_overflow);
554 pop(r14); 554 pop(r14);
555 bind(&done); 555 bind(&done);
556 if (and_then == kReturnAtEnd) { 556 if (and_then == kReturnAtEnd) {
557 Ret(); 557 Ret();
558 } 558 }
559 } 559 }
(...skipping 4964 matching lines...) Expand 10 before | Expand all | Expand 10 after
5524 } 5524 }
5525 if (mag.shift > 0) ShiftRightArith(result, result, Operand(mag.shift)); 5525 if (mag.shift > 0) ShiftRightArith(result, result, Operand(mag.shift));
5526 ExtractBit(r0, dividend, 31); 5526 ExtractBit(r0, dividend, 31);
5527 AddP(result, r0); 5527 AddP(result, r0);
5528 } 5528 }
5529 5529
5530 } // namespace internal 5530 } // namespace internal
5531 } // namespace v8 5531 } // namespace v8
5532 5532
5533 #endif // V8_TARGET_ARCH_S390 5533 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698