Better record compile-time errors on elements

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compiler_base;
 
 import 'dart:async' show
     EventSink,
     Future;
 
@@ skipping 336 matching lines @@
 
   /// The [int.fromEnvironment] constructor.
   ConstructorElement intEnvironment;
 
   /// The [bool.fromEnvironment] constructor.
   ConstructorElement boolEnvironment;
 
   /// The [String.fromEnvironment] constructor.
   ConstructorElement stringEnvironment;
 
+  // TODO(zarah): Remove this map and incorporate compile-time errors
+  // in the model.
   /// Tracks elements with compile-time errors.
-  final Map<Element, DiagnosticMessage> elementsWithCompileTimeErrors =
-      new Map<Element, DiagnosticMessage>();
+  final Map<Element, List<DiagnosticMessage>> elementsWithCompileTimeErrors =
+      new Map<Element, List<DiagnosticMessage>>();
 
   fromEnvironment(String name) => null;
 
   Element get currentElement => _reporter.currentElement;
 
   List<CompilerTask> tasks;
   ScannerTask scanner;
   DietParserTask dietParser;
   ParserTask parser;
   PatchParserTask patchParser;
@@ skipping 1078 matching lines @@
 
   /// Returns [true] if a compile-time error has been reported for element.
   bool elementHasCompileTimeError(Element element) {
     return elementsWithCompileTimeErrors.containsKey(element);
   }
 
   /// Associate [element] with a compile-time error [message].
   void registerCompiletimeError(Element element, DiagnosticMessage message) {
     // The information is only needed if [generateCodeWithCompileTimeErrors].
     if (generateCodeWithCompileTimeErrors) {
-      elementsWithCompileTimeErrors[element] = message;
+      if (element == null) {
+        // Record as global error.
+        // TODO(zarah): Extend element model to represent compile-time
+        // errors instead of using a map.
+        elementsWithCompileTimeErrors.

[Johnni Winther, 2016/03/31 09:59:34]

Maybe just:

if (element == null) {
  // ....
  element = mainFunction;
}
elementsWithCompileTimeError.putIfAbsent(element, ...

[zarah, 2016/04/01 07:29:52]

Done.

+            putIfAbsent(mainFunction, () => <DiagnosticMessage>[]).add(message);
+      } else {
+        elementsWithCompileTimeErrors.
+            putIfAbsent(element, () => <DiagnosticMessage>[]).add(message);
+      }
     }
   }
 
   EventSink<String> outputProvider(String name, String extension) {
     if (compilationFailed) {
       if (!generateCodeWithCompileTimeErrors || testMode) {
         // Disable output in test mode: The build bot currently uses the time
         // stamp of the generated file to determine whether the output is
         // up-to-date.
         return new NullSink('$name.$extension');
@@ skipping 249 matching lines @@
     reportDiagnostic(message, infos, kind);
   }
 
   void reportDiagnostic(DiagnosticMessage message,
                         List<DiagnosticMessage> infos,
                         api.Diagnostic kind) {
     if (kind == api.Diagnostic.ERROR ||
         kind == api.Diagnostic.CRASH ||
         (options.fatalWarnings &&
          kind == api.Diagnostic.WARNING)) {
-      compiler.registerCompiletimeError(currentElement, message);
+      if (message.spannable is Element) {
+        errorElement = message.spannable;
+      } else {
+        errorElement = currentElement;
+      }
+      compiler.registerCompiletimeError(errorElement, message);
       compiler.compilationFailed = true;
     }
     compiler.reportDiagnostic(message, infos, kind);
   }
 
   /**
    * Perform an operation, [f], returning the return value from [f].  If an
    * error occurs then report it as having occurred during compilation of
    * [element].  Can be nested.
    */
@@ skipping 371 matching lines @@
     if (_otherDependencies == null) {
       _otherDependencies = new Setlet<Element>();
     }
     _otherDependencies.add(element.implementation);
   }
 
   Iterable<Element> get otherDependencies {
     return _otherDependencies != null ? _otherDependencies : const <Element>[];
   }
 }