content/shell/browser/layout_test/layout_test_push_messaging_service.cc - Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default

Patch Set: Address review comments, and rewrite following rebase (e.g. no longer depends on NestedMessagePumpA… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h ('K') | « content/shell/browser/layout_test/layout_test_push_messaging_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

index c191ffd5937a5983948291780c642e787d156000..a858f48634a53049f5ca4e4c0cf9fdaccffe821f 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

@@ -125,7 +125,6 @@ bool LayoutTestPushMessagingService::SupportNonVisibleMessages() {

void LayoutTestPushMessagingService::Unsubscribe(

const GURL& requesting_origin,

int64_t service_worker_registration_id,

- const std::string& sender_id,

const UnregisterCallback& callback) {

callback.Run(PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTERED);

}