content/shell/browser/layout_test/layout_test_push_messaging_service.cc - Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default

Patch Set: Address review comments, and rewrite following rebase (e.g. no longer depends on NestedMessagePumpA… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h ('K') | « content/shell/browser/layout_test/layout_test_push_messaging_service.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/shell/browser/layout_test/layout_test_push_messaging_service.h "	5 #include "content/shell/browser/layout_test/layout_test_push_messaging_service.h "

6	6

7 #include "base/callback.h"	7 #include "base/callback.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "content/public/browser/permission_type.h"	10 #include "content/public/browser/permission_type.h"

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
118 ->GetPermissionStatus(PermissionType::PUSH_MESSAGING, origin, origin));	118 ->GetPermissionStatus(PermissionType::PUSH_MESSAGING, origin, origin));

119 }	119 }

120	120

121 bool LayoutTestPushMessagingService::SupportNonVisibleMessages() {	121 bool LayoutTestPushMessagingService::SupportNonVisibleMessages() {

122 return false;	122 return false;

123 }	123 }

124	124

125 void LayoutTestPushMessagingService::Unsubscribe(	125 void LayoutTestPushMessagingService::Unsubscribe(

126 const GURL& requesting_origin,	126 const GURL& requesting_origin,

127 int64_t service_worker_registration_id,	127 int64_t service_worker_registration_id,

128 const std::string& sender_id,

129 const UnregisterCallback& callback) {	128 const UnregisterCallback& callback) {

130 callback.Run(PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTERED);	129 callback.Run(PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTERED);

131 }	130 }

132	131

133 } // namespace content	132 } // namespace content

OLD	NEW