Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: runtime/observatory/lib/src/elements/class_view.dart

Issue 1851293005: Improve CPU Profile View (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/class_view.dart
diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart
index c13cbb36fad03292857b19b3f00c0bbc8090eef5..b1ac3fca46e6aca9e31a5172075afc2872eeef2a 100644
--- a/runtime/observatory/lib/src/elements/class_view.dart
+++ b/runtime/observatory/lib/src/elements/class_view.dart
@@ -20,7 +20,7 @@ class ClassViewElement extends ObservatoryElement {
@observable ObservableList mostRetained;
SampleBufferControlElement sampleBufferControlElement;
StackTraceTreeConfigElement stackTraceTreeConfigElement;
- CpuProfileTreeElement cpuProfileTreeElement;
+ CpuProfileVirtualTreeElement cpuProfileTreeElement;
ClassViewElement.created() : super.created();
@@ -70,6 +70,7 @@ class ClassViewElement extends ObservatoryElement {
assert(stackTraceTreeConfigElement != null);
stackTraceTreeConfigElement.onTreeConfigChange = onTreeConfigChange;
stackTraceTreeConfigElement.show = false;
+ stackTraceTreeConfigElement.showFilter = false;
cpuProfileTreeElement = shadowRoot.querySelector('#cpuProfileTree');
assert(cpuProfileTreeElement != null);
cpuProfileTreeElement.profile = sampleBufferControlElement.profile;
@@ -94,7 +95,9 @@ class ClassViewElement extends ObservatoryElement {
cpuProfileTreeElement.render();
}
- onTreeConfigChange(String modeSelector, String directionSelector) {
+ onTreeConfigChange(String modeSelector,
+ String directionSelector,
+ String filter) {
ProfileTreeDirection direction = ProfileTreeDirection.Exclusive;
if (directionSelector != 'Up') {
direction = ProfileTreeDirection.Inclusive;
« no previous file with comments | « runtime/observatory/lib/src/app/view_model.dart ('k') | runtime/observatory/lib/src/elements/class_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698