Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebSpeechRecognizer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index 90a0bc0e7827b9e2e896caf7894ef499895a9b35..19ccccb09618088f9143a10fc788bd7f7276ce22 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -155,19 +155,19 @@ public:
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientCallbacks implementation.
- virtual void getClient(const WebString&, WebServiceWorkerClientCallbacks* callbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void getClient(const WebString&, WebServiceWorkerClientCallbacks*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientsInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void getClients(const WebServiceWorkerClientQueryOptions&, WebServiceWorkerClientsCallbacks* callbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void getClients(const WebServiceWorkerClientQueryOptions&, WebServiceWorkerClientsCallbacks*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void openWindow(const WebURL& url, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) = 0;
// A suggestion to cache this metadata in association with this URL.
virtual void setCachedMetadata(const WebURL& url, const char* data, size_t size) { }
@@ -177,33 +177,33 @@ public:
// Callee receives ownership of the passed vector.
// FIXME: Blob refs should be passed to maintain ref counts. crbug.com/351753
- virtual void postMessageToClient(const WebString& uuid, const WebString&, WebMessagePortChannelArray*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void postMessageToClient(const WebString& uuid, const WebString&, WebMessagePortChannelArray*) = 0;
// Callee receives ownership of the passed vector.
// FIXME: Blob refs should be passed to maintain ref counts. crbug.com/351753
- virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString&, WebMessagePortChannelArray*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString&, WebMessagePortChannelArray*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after run.
- virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after run.
- virtual void claim(WebServiceWorkerClientsClaimCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callback after calling either onSuccess or onError.
- virtual void focus(const WebString& uuid, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void focus(const WebString& uuid, WebServiceWorkerClientCallbacks*) = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void navigate(const WebString& uuid, const WebURL&, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void navigate(const WebString& uuid, const WebURL&, WebServiceWorkerClientCallbacks*) = 0;
// Called when the worker wants to register subscopes to handle via foreign
// fetch. Will only be called while an install event is in progress.
- virtual void registerForeignFetchScopes(const WebVector<WebURL>& subScopes, const WebVector<WebSecurityOrigin>& origins) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void registerForeignFetchScopes(const WebVector<WebURL>& subScopes, const WebVector<WebSecurityOrigin>& origins) = 0;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/web/WebSpeechRecognizer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698