third_party/WebKit/public/web/WebSpeechRecognizer.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebSpeechRecognizer.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebSpeechRecognizer.h

diff --git a/third_party/WebKit/public/web/WebSpeechRecognizer.h b/third_party/WebKit/public/web/WebSpeechRecognizer.h

index f43d5a6fa70577bc480b358a096584a806501c20..d5f88dbdc04657ab746b45f1bf49eae08a2fe5db 100644

--- a/third_party/WebKit/public/web/WebSpeechRecognizer.h

+++ b/third_party/WebKit/public/web/WebSpeechRecognizer.h

@@ -38,13 +38,13 @@ class WebSpeechRecognizerClient;

class WebSpeechRecognizer {

public:

// Start speech recognition for the specified handle using the specified parameters. Notifications on progress, results, and errors will be sent via the client.

- virtual void start(const WebSpeechRecognitionHandle&, const WebSpeechRecognitionParams&, WebSpeechRecognizerClient*) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void start(const WebSpeechRecognitionHandle&, const WebSpeechRecognitionParams&, WebSpeechRecognizerClient*) = 0;

// Stop speech recognition for the specified handle, returning any results for the audio recorded so far. Notifications and errors are sent via the client.

- virtual void stop(const WebSpeechRecognitionHandle&, WebSpeechRecognizerClient*) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void stop(const WebSpeechRecognitionHandle&, WebSpeechRecognizerClient*) = 0;

// Abort speech recognition for the specified handle, discarding any recorded audio. Notifications and errors are sent via the client.

- virtual void abort(const WebSpeechRecognitionHandle&, WebSpeechRecognizerClient*) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void abort(const WebSpeechRecognitionHandle&, WebSpeechRecognizerClient*) = 0;

protected:

virtual ~WebSpeechRecognizer() { }