third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebVector.h ('k') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseCallbacks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h

index e9bcfc399d0e6e1c5ae2b2739c5f8e8deb259f61..c621ba9719a07b8c302e9b2b4b54ff454dfe81a8 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h

@@ -38,8 +38,8 @@ class WebIDBCursor {

public:

virtual ~WebIDBCursor() { }

- virtual void advance(unsigned long, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }

- virtual void continueFunction(const WebIDBKey&, const WebIDBKey& primaryKey, WebIDBCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void advance(unsigned long, WebIDBCallbacks*) = 0;

+ virtual void continueFunction(const WebIDBKey&, const WebIDBKey& primaryKey, WebIDBCallbacks*) = 0;

virtual void postSuccessHandlerCallback() { } // Only used in frontend.

protected: