third_party/WebKit/public/platform/WebVector.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebVector.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebRTCKeyParams.h ('k') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebVector.h

diff --git a/third_party/WebKit/public/platform/WebVector.h b/third_party/WebKit/public/platform/WebVector.h

index f45c252b0298dc6a017827c43afcc508aa00ad1a..27a372417bc19988ab40edee4da2ceb409fb0bf8 100644

--- a/third_party/WebKit/public/platform/WebVector.h

+++ b/third_party/WebKit/public/platform/WebVector.h

@@ -32,6 +32,7 @@

#define WebVector_h

#include "WebCommon.h"

+#include "base/logging.h"

#include <algorithm>

#include <vector>

@@ -124,13 +125,13 @@ public:

T& operator[](size_t i)

{

- BLINK_ASSERT(i < m_data.size());

+ DCHECK_LT(i, m_data.size());

return m_data[i];

}

const T& operator[](size_t i) const

{

- BLINK_ASSERT(i < m_data.size());

+ DCHECK_LT(i, m_data.size());

return m_data[i];

}