third_party/WebKit/public/platform/WebCommon.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebCommon.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebBlobRegistry.h ('k') | third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebCommon.h

diff --git a/third_party/WebKit/public/platform/WebCommon.h b/third_party/WebKit/public/platform/WebCommon.h

index 9d0a40af61826fe6ff035cb73b18b9cb2893a29f..d79078589fdd31eeab1b110b293f5f3e3e02cfd4 100644

--- a/third_party/WebKit/public/platform/WebCommon.h

+++ b/third_party/WebKit/public/platform/WebCommon.h

@@ -93,23 +93,6 @@ typedef unsigned short WebUChar;

// Latin-1 character type

typedef unsigned char WebLChar;

-// -----------------------------------------------------------------------------

-// Assertions

-BLINK_COMMON_EXPORT void failedAssertion(const char* file, int line, const char* function, const char* assertion);

} // namespace blink

-// Ideally, only use inside the public directory but outside of INSIDE_BLINK blocks. (Otherwise use WTF's ASSERT.)

-#if defined(NDEBUG)

-#define BLINK_ASSERT(assertion) ((void)0)

-#else

-#define BLINK_ASSERT(assertion) do { \

- if (!(assertion)) \

- failedAssertion(__FILE__, __LINE__, __FUNCTION__, #assertion); \

-} while (0)

-#endif

-#define BLINK_ASSERT_NOT_REACHED() BLINK_ASSERT(0)

#endif