Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: third_party/WebKit/public/platform/WebBlobRegistry.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/DEPS ('k') | third_party/WebKit/public/platform/WebCommon.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebBlobRegistry.h
diff --git a/third_party/WebKit/public/platform/WebBlobRegistry.h b/third_party/WebKit/public/platform/WebBlobRegistry.h
index 9a5842b4c3b359b1f0d09707d0ed9ea55c9a338d..6ec7e6cc0c96581ef244221ce32c0acdf874e319 100644
--- a/third_party/WebKit/public/platform/WebBlobRegistry.h
+++ b/third_party/WebKit/public/platform/WebBlobRegistry.h
@@ -77,7 +77,7 @@ public:
// Caller takes ownership of the Builder. The blob is finalized (and sent to
// the browser) on calling build() on the Builder object.
- virtual Builder* createBuilder(const WebString& uuid, const WebString& contentType) { BLINK_ASSERT_NOT_REACHED(); return nullptr; }
+ virtual Builder* createBuilder(const WebString& uuid, const WebString& contentType) = 0;
virtual void addBlobDataRef(const WebString& uuid) { }
virtual void removeBlobDataRef(const WebString& uuid) { }
@@ -86,28 +86,28 @@ public:
// Registers a stream URL referring to a stream with the specified media
// type.
- virtual void registerStreamURL(const WebURL&, const WebString&) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void registerStreamURL(const WebURL&, const WebString&) = 0;
// Registers a stream URL referring to the stream identified by the
// specified srcURL.
- virtual void registerStreamURL(const WebURL&, const WebURL& srcURL) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void registerStreamURL(const WebURL&, const WebURL& srcURL) = 0;
// Add data to the stream referred by the URL.
- virtual void addDataToStream(const WebURL&, const char* data, size_t length) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void addDataToStream(const WebURL&, const char* data, size_t length) = 0;
// Flush contents buffered in the stream to the corresponding reader.
- virtual void flushStream(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void flushStream(const WebURL&) = 0;
// Tell the registry that construction of this stream has completed
// successfully and so it won't receive any more data.
- virtual void finalizeStream(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void finalizeStream(const WebURL&) = 0;
// Tell the registry that construction of this stream has been aborted and
// so it won't receive any more data.
- virtual void abortStream(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void abortStream(const WebURL&) = 0;
// Unregisters a stream referred by the URL.
- virtual void unregisterStreamURL(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void unregisterStreamURL(const WebURL&) = 0;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/platform/DEPS ('k') | third_party/WebKit/public/platform/WebCommon.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698