third_party/WebKit/public/web/WebFrameClient.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gn compilation. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/mock_webframeclient.h ('K') | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h ('k') | third_party/WebKit/public/web/WebSpeechRecognizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebFrameClient.h

diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h

index 5fd21c9dc1ceb855c01633ff06731e3ecf9f89b1..bf066d11a4617730e61f0fa05f434fa7ca40aca0 100644

--- a/third_party/WebKit/public/web/WebFrameClient.h

+++ b/third_party/WebKit/public/web/WebFrameClient.h

@@ -721,7 +721,7 @@ public:

// Checks that the given audio sink exists and is authorized. The result is provided via the callbacks.

// This method takes ownership of the callbacks pointer.

- virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) = 0;

liberato (no reviews please) 2016/04/06 14:39:43 everything else in the default implementation retu

kotenkov 2016/04/07 06:03:28 Yes, this is the precise reason: https://coderevie

protected:

virtual ~WebFrameClient() { }