Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

third_party/WebKit/public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 703 matching lines @@
     virtual WebBluetooth* bluetooth() { return 0; }
 
     // WebUSB --------------------------------------------------------------
     virtual WebUSBClient* usbClient() { return nullptr; }
 
 
     // Audio Output Devices API --------------------------------------------
 
     // Checks that the given audio sink exists and is authorized. The result is provided via the callbacks.
     // This method takes ownership of the callbacks pointer.
-    virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+    virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) = 0;

[liberato (no reviews please), 2016/04/06 14:39:43]

everything else in the default implementation returns something similar to "no".
 why was this an assert rather than cb->OnError(NotSupported)?

is it because of the "takes ownership" part?  could one just delete the cb
before returning?

[kotenkov, 2016/04/07 06:03:28]

Yes, this is the precise reason:
https://codereview.chromium.org/1416123005/diff2/80001:100001/third_party/Web...
I guess, nobody had thought about it before you suggested it. =)

 
 protected:
     virtual ~WebFrameClient() { }
 };
 
 } // namespace blink
 
 #endif