Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

third_party/WebKit/public/platform/WebCommon.h

Index: third_party/WebKit/public/platform/WebCommon.h
diff --git a/third_party/WebKit/public/platform/WebCommon.h b/third_party/WebKit/public/platform/WebCommon.h
index 9d0a40af61826fe6ff035cb73b18b9cb2893a29f..e0cba51b6d65d1021c0a6adb7bce758739bd7663 100644
--- a/third_party/WebKit/public/platform/WebCommon.h
+++ b/third_party/WebKit/public/platform/WebCommon.h
@@ -73,6 +73,11 @@
 
 
 // -----------------------------------------------------------------------------
+// Assertions
+
+#include "base/logging.h"

[tkent, 2016/04/03 22:59:06]

WebCommon.h shouldn't include base/logging.h.  Each of files using DCHECK should
include base/logging.h.

[haraken, 2016/04/03 23:53:46]

This is a tricky part since core/, modules/ and web/ are not allowed to include
base/. But we want to allow core/, modules/ and web/ to use macros defined in
Chromium.

As far as I understand, our plan is:

- For normal classes, define a thin wrapper in wtf/ or platform/ to be used by
core/, modules/ and web/
- For macros, allow core/, modules/ and web/ to use them directly.
- core/, modules/ and web/ cannot include base/ anyway.

To meet the requirements, maybe do we need to introduce wtf/macros.h which
includes base/logging.h etc? Or would there be any better way?

[kotenkov, 2016/04/04 07:46:34]

There already exists such a file: wtf/Assertions.h. The problem is that we
cannot include wtf from outside of BLINK_IMPLEMENTATION.

[tkent, 2016/04/04 09:03:17]

Right.  So, I think using base/logging.h directly in public/platform is a
reasonable exception.

+
+// -----------------------------------------------------------------------------
 // Basic types
 
 #include <stddef.h> // For size_t
@@ -93,23 +98,6 @@ typedef unsigned short WebUChar;
 // Latin-1 character type
 typedef unsigned char WebLChar;
 
-// -----------------------------------------------------------------------------
-// Assertions
-
-BLINK_COMMON_EXPORT void failedAssertion(const char* file, int line, const char* function, const char* assertion);

[tkent, 2016/04/03 22:59:06]

We should remove failedAssertion() implementation in
platform/exported/WebCommon.cpp.

-
 } // namespace blink
 
-// Ideally, only use inside the public directory but outside of INSIDE_BLINK blocks.  (Otherwise use WTF's ASSERT.)
-#if defined(NDEBUG)
-#define BLINK_ASSERT(assertion) ((void)0)
-#else
-#define BLINK_ASSERT(assertion) do { \
-    if (!(assertion)) \
-        failedAssertion(__FILE__, __LINE__, __FUNCTION__, #assertion); \
-} while (0)
-#endif
-
-#define BLINK_ASSERT_NOT_REACHED() BLINK_ASSERT(0)
-
 #endif